Repository navigation
Fix iterate end linear free - #425
Merged
Merged
Conversation
ucl_object_iterate_end frees *it as a hash iterator whenever obj is a
UCL_OBJECT. That is only true for expand_values = true. Without it,
ucl_object_iterate_with_error walks obj as a linear list and *it is a
position in that list - obj itself, or one of its next elements - so
abandoning the iteration, as ucl.h documents, frees that object:
ucl_object_iterate_with_error(obj, &it, false, NULL); /* it == obj */
ucl_object_iterate_end(obj, &it); /* frees obj */
ucl_object_unref(obj); /* use-after-free */
Check whether *it is one of the objects in obj's own list before freeing; if
it is, the iterator is a linear position and there is nothing to free. The
list is short and only abandoned iterations reach this code.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W3aXdPKAnVwjiNtZstnmPj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #424