Store hot and cold random access benchmark results - #9649
Conversation
Signed-off-by: Will Manning <will@willmanning.io>
…ot-cold Signed-off-by: Will Manning <will@willmanning.io>
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cold_misaligned[(16, 64)] |
345.6 µs | 392.8 µs | -12.02% |
| ⚡ | WallTime | arrow_checked_add_u32_avx2[16384] |
21.3 µs | 17.7 µs | +20.38% |
| ⚡ | WallTime | mul_u32_nonnull_avx512 |
6.3 µs | 5.6 µs | +12.03% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wm/random-access-hot-cold (614e43f) with develop (f880575)
Footnotes
-
106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53c97b4dfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ot-cold Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
connortsui20
left a comment
There was a problem hiding this comment.
this seems fine, unclear how exactly this links to vortex-data/benchmarks-website#26 but I guess we will see
Summary
Store both cached-accessor and per-take reopen timings from the random access benchmark. The benchmark already runs both modes, but v3 reporting discards reopen results. This prevents the benchmark site from comparing the two access paths.
Changes
Add
open_modeto random-access v3 records and Postgres ingestion. Cached records preserve historical measurement IDs. Reopen records use distinct IDs. Focused producer, snapshot, and measurement-ID tests cover the field.