Skip to content

Simplify StatsRewriteCtx rules by leveraging BoundExpressions - #9643

Open
robert3005 wants to merge 3 commits into
developfrom
rk/boundstatsrewrite
Open

Simplify StatsRewriteCtx rules by leveraging BoundExpressions#9643
robert3005 wants to merge 3 commits into
developfrom
rk/boundstatsrewrite

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Since we have BoundExpressions we don't have to go through the StatsRewriteCtx
to resolve the dtype anymore

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Aug 26, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) August 26, 2026 16:57
@codspeed-hq

codspeed-hq Bot commented Aug 26, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2109 untouched benchmarks
🆕 18 new benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compact[(2048, 90)] 1.4 µs 1.5 µs -10.71%
WallTime arrow_checked_add_u32_neon[16384] 20.3 µs 13.6 µs +49.62%
WallTime arrow_checked_add_u32_avx512[16384] 21.2 µs 17.6 µs +20.46%
🆕 WallTime infallible_bool_neon[i32, ConstantPerRow] N/A 4.3 µs N/A
🆕 WallTime infallible_bool_neon[i32, PerRowConstant] N/A 4.2 µs N/A
🆕 WallTime infallible_bool_neon[i32, PerRowPerRow] N/A 3.7 µs N/A
🆕 WallTime infallible_bool_neon[i64, ConstantPerRow] N/A 5.6 µs N/A
🆕 WallTime infallible_bool_neon[i64, PerRowConstant] N/A 5.6 µs N/A
🆕 WallTime infallible_bool_neon[i64, PerRowPerRow] N/A 5.5 µs N/A
🆕 WallTime infallible_bool_avx2[i32, ConstantPerRow] N/A 3.8 µs N/A
🆕 WallTime infallible_bool_avx2[i32, PerRowConstant] N/A 3.7 µs N/A
🆕 WallTime infallible_bool_avx2[i32, PerRowPerRow] N/A 2.9 µs N/A
🆕 WallTime infallible_bool_avx2[i64, ConstantPerRow] N/A 10 µs N/A
🆕 WallTime infallible_bool_avx2[i64, PerRowConstant] N/A 10 µs N/A
🆕 WallTime infallible_bool_avx2[i64, PerRowPerRow] N/A 10.4 µs N/A
🆕 WallTime infallible_bool_avx512[i32, ConstantPerRow] N/A 3.3 µs N/A
🆕 WallTime infallible_bool_avx512[i32, PerRowConstant] N/A 3.3 µs N/A
🆕 WallTime infallible_bool_avx512[i32, PerRowPerRow] N/A 2.3 µs N/A
🆕 WallTime infallible_bool_avx512[i64, ConstantPerRow] N/A 4.1 µs N/A
🆕 WallTime infallible_bool_avx512[i64, PerRowConstant] N/A 4 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/boundstatsrewrite (e05e7ea) with develop (0a128b6)3

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

  3. No successful run was found on develop (28f7cf0) during the generation of this report, so 0a128b6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant