Show mount/wait dialog on the monitor of the main window - #1865
Open
amail80 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a multi-monitor setup the wait dialog shown while mounting or dismounting always appears on the primary monitor, even when the main window is on another one. The user is looking at the main window and the progress indication shows up on a different screen.
The dialog is created with a hidden tool window as its parent rather than with the main window, so the usual centering on the owner does not apply. This reads the creator window's rectangle with GetWindowRect and centers the dialog on the monitor that rectangle belongs to, falling back to the previous behaviour when there is no creator window.
Tested on Windows 11 with two monitors at different scale factors, with the main window on the secondary display: the wait dialog now appears next to it instead of on the primary monitor.