Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run
apt-get -y upgradebefore installing the vDSM packages.Why
The image copies its entire base from a pinned
qemux/qemutag, which carries over that tag's Debian packages as they were on its build day. Nothing refreshes them whenvirtual-dsmis rebuilt, so Debian security updates released after the base was built never reach users.vdsm/virtual-dsm:latest(7.66, baseqemux/qemu:7.50) scanned with Trivy today (DB of 2026-10-27):latestmasterThe upgrade updated 43 packages. QEMU is left alone because the sid snapshot source is removed in the base, so trixie has nothing newer to offer for it.
The 47 fixable findings that remain are all in the Go binaries
/run/host.bin(Go 1.26.5) and/run/boot-logo(Go 1.25.7). They need a rebuild of those projects with a current Go toolchain, which is out of scope here.Testing
docker buildx build. No conffile prompts, exit 0./dev/kvm, an empty/storageand the default URL. It downloaded and installed DSM 7.2.2-72806, booted, the healthcheck reportedhealthy, and port 5000 served the "Welcome to DSM 7.2" page.Trade-off
The upgrade lands in the vDSM layer, so the image grows from about 758 MB to 931 MB on disk. Doing the same in the
qemux/qemuDockerfile would avoid that, but it would only help once the pinned base tag is bumped.