Skip to content

Permanent admins committed in the app: acgetchell, bmceligot - #87

Closed
NDL3wis wants to merge 1 commit into
mainfrom
feat/permanent-admins
Closed

NDL3wis wants to merge 1 commit into
mainfrom
feat/permanent-admins

Conversation

@NDL3wis

@NDL3wis NDL3wis commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Why

acgetchell and bmceligot should be permanent JDWriter admins: admins who can't be removed in Settings. Until now the only permanent admins were those in Admin__BootstrapLoginIds, an App Service setting that CRU manages. Changing it would have meant a change in Azure.

What changed

  • A new setting, Admin:PermanentLoginIds in server/appsettings.json, lists permanent admins inside the app. It starts with acgetchell,bmceligot.
  • AdminAccess.ConfiguredAdmins is now the union of that list and Admin:BootstrapLoginIds. The Azure setting is unchanged and still applies.
  • It's a separate key because an App Service setting with the same name would replace the JSON value rather than add to it.
  • In Settings → Admins, the two show the "set in server configuration" badge instead of Remove, and RevokeAsync refuses them.
  • They're permanent admins in every environment that runs this build, local and test included.
  • Docs updated: API-CONTRACT.md and RUNNING-LOCALLY.md.

Validation

  • dotnet test --filter "Category!=CorpusParity": 830 passed, 1 failed. The failure is StructuredLlmLiveTests (Category=LiveApi), which needs a real API key in the test host and which CI's .runsettings excludes.
  • New tests:
    • permanent admins are combined with the bootstrap admins, normalized and de-duplicated, and can't be revoked;
    • the committed appsettings.json names both logins.
  • Not checked in a running app.

Deployment notes

Merging deploys to prod. No migration and no Azure configuration change. Both users already have in-app grants, so their access doesn't change; they just can no longer be removed in the app.

🤖 Generated with Claude Code

… Azure

Admin:PermanentLoginIds in server/appsettings.json names admins who, like the
Azure-configured Admin:BootstrapLoginIds, cannot be removed from the app. It is a
separate key because an App Service setting replaces a JSON value of the same name
rather than adding to it. Adds acgetchell and bmceligot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4a154159-5239-45c8-9eb3-02014ce72ddf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@NDL3wis

NDL3wis commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Closed in favour of a permanent flag set in the app, so admin login IDs aren't published in the repo.

@NDL3wis NDL3wis closed this Nov 4, 2026
@NDL3wis
NDL3wis deleted the feat/permanent-admins branch November 4, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant