Repository navigation
Conversation
… Azure Admin:PermanentLoginIds in server/appsettings.json names admins who, like the Azure-configured Admin:BootstrapLoginIds, cannot be removed from the app. It is a separate key because an App Service setting replaces a JSON value of the same name rather than adding to it. Adds acgetchell and bmceligot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Collaborator
Author
|
Closed in favour of a permanent flag set in the app, so admin login IDs aren't published in the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
acgetchell and bmceligot should be permanent JDWriter admins: admins who can't be removed in Settings. Until now the only permanent admins were those in
Admin__BootstrapLoginIds, an App Service setting that CRU manages. Changing it would have meant a change in Azure.What changed
Admin:PermanentLoginIdsinserver/appsettings.json, lists permanent admins inside the app. It starts withacgetchell,bmceligot.AdminAccess.ConfiguredAdminsis now the union of that list andAdmin:BootstrapLoginIds. The Azure setting is unchanged and still applies.RevokeAsyncrefuses them.API-CONTRACT.mdandRUNNING-LOCALLY.md.Validation
dotnet test --filter "Category!=CorpusParity": 830 passed, 1 failed. The failure isStructuredLlmLiveTests(Category=LiveApi), which needs a real API key in the test host and which CI's.runsettingsexcludes.appsettings.jsonnames both logins.Deployment notes
Merging deploys to prod. No migration and no Azure configuration change. Both users already have in-app grants, so their access doesn't change; they just can no longer be removed in the app.
🤖 Generated with Claude Code