Skip directories while scanning Swift sources - #357
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Inspect enumerated resource types so .swift-suffixed directories and directory symlinks are not parsed as source files, while preserving symlinks to files. Add regression coverage for both filesystem boundaries.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.swift-suffixed directories and directory/file symlink boundariesFixes #356
Testing
swift test --filter FileScannerTests(2 tests)swift test(158 XCTest tests and 3 Swift Testing tests)swift buildswift run mockolo -j 4 -s .build/issue-356-reproduction/Sources -d .build/issue-356-reproduction/Generated-swift-run.swift