Repository navigation
fix: read an inherited property's readonly-ness from the base type that supplies it - #1057
Open
YevheniiKotyrlo wants to merge 1 commit into
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
An interface inherits a mapped type's property symbol as-is, so
isPropertyReadonlyInTypeasked the interface — which isn't the mapped type — and fell back to the declaration the mapped type mapped.For a class or interface,
isReadonlyPropertyFromBaseTypenow finds the base type that supplies the same symbol (typeChecker.getBaseTypes) and asks about that base type instead, after the mapped-type check.The new tests cover
Readonly<Box>,Readonly<Pick<Box, "value">>, a chain of two interfaces, the readonly base among several base types, a-readonlymapping of a readonly declaration, andPartial<Box>; the first five fail without the change.All CI steps pass locally on Node 26, with the suite also run on TypeScript 5.5.4 and 5.9.3.
#1056 isn't triaged yet, so the second and third boxes stay unchecked; I'm sending the fix now so it can be read alongside the report.