Repository navigation
Conversation
Accept cast keywords as expression names so argument values can continue into scoped calls and compound expressions. Keep class-name aliases limited to cast spellings that PHP permits as class identifiers. Accept type keywords in valid global and class constant declarations, with coverage for reserved names, typed constants, casts, and named arguments. Restore example parsing for the affected WordPress file. Fixes #295.
Regenerate both PHP parsers for keyword identifier and constant fixes.
Prepare the keyword identifier and constant parsing fixes for release. Keep package manifests, lockfiles, and parser metadata in sync.
|
Tested this branch (head 74de061, built as the Python binding) against real code, and it fixes the typed case too, which the corpus only covers with
In case it helps, here is a corpus case for keyword-named typed constants (final, optional, union and named types, in a class, an interface and an enum). It fails on master and passes on this branch: alexwrite@9678351 Thanks for the fix. |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295