Conversation
…cessary lint expect This was fixed with rust 1.99
new with rust 1.99
fixes the new rust 1.99 "double_must_use" lint issue
As the async part was practically not used and only blockingly awaited anyway.
As it is now no longer used.
And related functionality. As it was now completely unused since the server became the only one to modify the playlist.
So that no functions are accidentally available for calling. Also now consumers dont need to import PlayerTrait anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans-up the playback's
lib.rsa bit:async-trait, as we dont actually really use itPlayerTraitonGeneralPlayeranymore so that we dont accidentally expose functions that should not be called directly anymoreDepends on #789