Repository navigation
Conversation
The persona request is refused for free users and the empty result was cached, so a buyer saw no persona until a manual reload. Invalidate the query on a VIP update, as the Reality Check queries already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads the Year in Review persona for a free user right after they buy VIP, without a manual reload.
What changed
yirPersonaQuerynow listsInvalidateAction.Vip.Updatedin its invalidations. The checkout confirmation already fires that action, so the mounted persona query refetches. This is the same approach the Reality Check queries use.Tests
yirPersonaQuery.spec.tsasserts the query key carries the VIP update action (same style as the Reality Check query specs).bun run test:unit --run src/lib/requests/queries/users/yirPersonaQuery).Not verified