fix(developer): keep guide redirect and contents specs in sync - #970
Merged
Merged
Conversation
Map /docs/api-use-policy and /docs/user-account-limits to their guides so every listed guide has a legacy redirect, and drop the hardcoded guide counts from the contents and redirect specs. The existing per-guide assertions already cover them, and the counts broke master whenever a guide was added.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last four
developer.ymlruns on master failed indeno task test, so nothing has deployed since.prepareGuideMarkdown.spec.tsexpected 29 guides. Addinguser-account-limitsmade it 30.legacyDocsDestination.spec.tsexpected 24 guides without theabout-prefix, but the guide list has 26. The redirect map was missingapi-use-policy(which landed on master while the redirect branch was open) anduser-account-limits.This PR:
/docs/api-use-policyand/docs/user-account-limitstoguideRedirects.json, so every guide in the list has a legacy redirect.about-prefix has a redirect. A new guide without a redirect now fails with its slug instead of a bare count. The redirect spec also checks that the guide list is not empty, so its loop can't pass without running.Validation