Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #965 (
feat/lists_search), which introducestermsQuerySchema. Review and merge that first; this PR's base retargets tomasteronce it merges.Summary
Documents the optional
termsquery param on the list item and watchlist routes, which the API now supports. When set, only items whose title contains the text are returned, case-insensitively: the movie or show title, the parent show's title for seasons, the show or episode title for episodes, and a person's name. Part of list search for trakt/trakt-web#1701.Changes
termsQuerySchemais merged into the query schema of every item-returning list and watchlist route:users.lists.list.itemsmovie,show,media,all,typedSortedusers.watchlistmovies,shows,media,typedSortedNo other schemas change.
Release
Additive and non-breaking: existing callers compile and behave as before. It can ship in the same patch tag as #965 (
v0.6.1).trakt-web does not have to wait for the release. The client serializes the query object without validating it, so
termsalready goes out on 0.6.0. The bump only adds typed access.Verification
deno check src/index.ts,deno fmtanddeno lintpass.deno task publish:checkcompletes its dry run withSuccess.