docs(developer): update third party libraries: go - #963
Conversation
91a1fae to
a2d5389
Compare
|
Hi @mfederowicz, thanks for the PR! Before we merge, please read our API Use Policy and confirm here that trakt-sync follows it. From a quick look it fits the "personal tool for your own data" use case, which is great. A few things we'd like also like to be clarified:
One more thing: this page lists libraries, and trakt-sync's client sits under internal/, so other Go projects can't import it. Would you like to expose it as a public package, or should we describe the entry as a CLI tool? Once those are sorted and you've confirmed compliance, we'll be happy to merge. Thanks again! |
|
ok @kevincador i read that api use policy, and added sugested notes in Readme.md, all sugested changes are deployed few minutes ago, you can check on releases: https://github.com/mfederowicz/trakt-sync/releases Please list trakt-sync as a CLI tool; the client stays internal for now (maybe in future we change that). |
|
Thanks @mfederowicz, that was quick! I checked v1.20.0 and v1.21.0 and everything we asked for is in. About the listing: since v1.21.0 moved the client into the public trakt package, it is a proper Go library now, so we'll keep it on the libraries page as it is. One small suggestion for library users: the default Merging this now. Thanks again for the contribution! |
Add the new Golang library to the README.
https://github.com/mfederowicz/trakt-sync
@kevincador can you look at this?