Repository navigation
fix(solidity): revalidate DKG results at approval and harden the DKG validator - #4384
piotr-roslaniec wants to merge 1 commit into
Conversation
…validator WalletRegistry approval now re-runs the DKG validator on the committed result and rejects a result that fails validation instead of registering a wallet. The read-only isDkgResultValid view answers (false, "validation reverted") instead of reverting. EcdsaDkgValidator tightens its input checks: bounds on the misbehaved and signing member indices and the members count, an on-curve check for the group public key, and signature recovery that returns false on malformed signatures. initializeV2_1 binds the validator for proxies upgraded from an earlier implementation. It is restricted to the proxy admin and requires an idle DKG. Storage layout is unchanged. Existing tests are updated for the revalidation gas cost and the new error messages.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
WalletRegistryapproval now revalidates the DKG result, andEcdsaDkgValidatorinput checks are tightened. The commit message lists the changes.This code is already live on Ethereum mainnet. The WalletRegistry upgrade executed on 12 November 2026, and the validator switch on 13 November:
0x14fad0c11c83ac736e5929d5661bba7e6bb9c0d60x1a5f4f753bd071c907714aefb6e0bcee32401406A build of this branch's commit reproduces the deployed runtime bytecode of both contracts (see below).
Please merge with a merge commit (the repository does not allow squash) so this commit stays in
mainhistory as the source of the deployed code.Bytecode check (16 November 2026). Built commit
8f4f8262edf02eec1e4fd9ddad55d72b10a3fff4with thesolidity/ecdsaCI steps (yarn install --immutable,yarn build; solc 0.8.17, optimizer 200 runs) and compared witheth_getCodeon mainnet, immutables masked:0x8263efcb8f28246697585c89fed0501cd946f764The four modified test files pass locally (290 passing, 21 pending).
Summary by CodeRabbit
Bug Fixes
New Features