Add tools/build.sh to automatically apply XLA/GCC compatibility patches - #4145
Open
Phoebus-Liu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #4108 by adding a
tools/build.shconvenience wrapper that automatically applies known compatibility patches before invokingrun_in_docker.sh.Problem
When building TF Serving from source with newer GCC versions (e.g., GCC 11/12/13), the build fails in
external/local_xla/xla/shape.ccwith:error: function 'xla::Shape::Shape(xla::Shape&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification 'noexcept(false)'
This is caused by
noexceptannotations on the move constructor/assignment that conflict with the implicit exception specification inferred by newer GCC/libstdc++.Solution
tools/build.shwhich:bazel fetchinside Docker to ensureexternal/dependencies are presentsedpatches toxla/shape.ccandxla/shape.hto remove the conflictingnoexcepton move operationstools/run_in_docker.shfor the actual buildUsage