Fix custom slot supplier SlotInfo fields - #3014
Merged
Merged
Conversation
Sushisource
reviewed
Aug 27, 2026
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Overall this makes sense, thanks for the fix. Just one comment.
| } | ||
| } | ||
|
|
||
| private static final class RecordingSlotSupplier implements SlotSupplier<WorkflowSlotInfo> { |
Member
There was a problem hiding this comment.
There are two copies of this (I think there might actually already be another too, that existed before this PR). We should just have all the tests re-use the same impl.
Contributor
Author
There was a problem hiding this comment.
Hi @Sushisource, thank you for catching this.
I’ve moved RecordingSlotSupplier to a shared test utility so both tests reuse the same implementation.
Could you please take another look? Thanks again!
baekgyu-kim
force-pushed
the
2650
branch
2 times, most recently
from
August 28, 2026 12:45
ff0bcf7 to
c1feac2
Compare
Sushisource
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowSlotInfoto report the normal task queue name for both normal and sticky workflow tasks.WorkflowSlotInfofrom the request that was actually polled.SlotInfofields, including synchronous/asynchronous and normal/sticky workflow polling.Why?
Custom slot suppliers could receive an empty or incorrect task queue, an incorrect sticky queue flag, or a missing/wrong worker build ID. These changes ensure that all supported
SlotInfotypes expose accurate worker and task information.Checklist
Closes Ensure tests exist to confirm custom slot supplier slot info has proper fields #2650
How was this tested:
./gradlew --offline spotlessApplygit diff --checkWorkflowSlotInfoTestSlotInfoTestSlotSupplierTestWorkerVersioningTestWorkerOptionsTestExternal-server-only versioning cases were skipped by their existing test conditions.
Any docs updates needed?
No. This change corrects existing
SlotInfobehavior and adds test coverage without changing the public API surface.