Skip to content

fix(deps): bump dhcproto to 0.15 to clear hickory-proto advisories (EVE-662) - #1

Merged
feisuzhu merged 1 commit into
masterfrom
binwang/eve-662
Nov 10, 2026
Merged

feisuzhu merged 1 commit into
masterfrom
binwang/eve-662

Conversation

@feisuzhu

@feisuzhu feisuzhu commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the two open Dependabot alerts on Cargo.lock by moving off the vulnerable hickory-proto.

Why this is the fix and not a dismissal

dhcproto 0.14 pins hickory-proto ^0.25.2; both advisories are fixed in 0.26.1+:

alert advisory range fixed in
#1 high GHSA-3v94-mw7p-v465 — NSEC3 closest-encloser proof unbounded loop 0.25.0-alpha.3 ..= 0.25.2 no separate fix published; 0.26.1 is out of range
#2 medium GHSA-q2qq-hmj6-3wpp — O(n²) name compression in the encoder 0.3.1 ..= 0.26.0 0.26.1

dhcproto 0.15.0 requires hickory-proto ^0.26.1, so a single requirement bump clears both. (Neither was reachable from this daemon — hickory is only used for its Name type in DHCP option encoding, default-features = false, no DNSSEC features — but carrying permanent deny.toml ignores for a fixed issue is worse than bumping.)

Changes

  • Cargo.toml: dhcproto = "0.14" → "0.15"
  • Cargo.lock: dhcproto 0.15.0, hickory-proto 0.26.3; new transitive deps jni, simdutf8, simd_cesu8, walkdir, walkdir's same-file/winapi-util; drops r-efi and rand 0.9
  • deny.toml: drop the RUSTSEC-2026-0118 / RUSTSEC-2026-0119 ignores and their now-stale comment

No source changes: the dhcproto::v4 API used here (Message, DhcpOption(s), MessageType, DecodeError, EncodeError) is unchanged in 0.15.

Verification (local, Rust 1.96)

  • cargo build --locked — ok
  • cargo test --locked --lib --bins — 170 passed
  • cargo clippy --locked --all-targets -- -D warnings -D clippy::unwrap_used -D clippy::expect_used -D clippy::panic -D clippy::as_conversions — clean
  • cargo fmt --all -- --check — clean
  • cargo deny check (0.20.2, ignores removed) — pending in CI

Note: cargo test --all-targets fails test_lease_persistence_across_restart on my workstation (post-restart ACK round-trip ~977 ms vs the 500 ms budget). It reproduces identically with this change stashed, so it is pre-existing and unrelated; CI skips the integration suite anyway.


Note

Medium Risk
Touches the DHCP dependency stack used for lease/option encoding; API is unchanged but transitive upgrades (hickory-proto, rand) warrant normal regression via build/tests.

Overview
Bumps dhcproto from 0.14 to 0.15 so the lockfile pulls hickory-proto 0.26.3 (via ^0.26.1), clearing the two Dependabot/RUSTSEC issues that were previously waived in deny.toml.

deny.toml drops the RUSTSEC-2026-0118 and RUSTSEC-2026-0119 ignore entries and their comment—cargo deny can enforce advisories again without exceptions.

Cargo.lock reflects the transitive graph change (e.g. rand 0.10.1, new jni/UTF-8 helper crates under hickory-proto); no application source changes—DHCP still uses the same dhcproto::v4 types (Message, DhcpOption(s), MessageType, encode/decode errors).

Reviewed by Cursor Bugbot for commit 8befd36. Bugbot is set up for automated code reviews on this repo. Configure here.

`dhcproto 0.14` pins `hickory-proto ^0.25.2`, which carries two open
advisories (GHSA-3v94-mw7p-v465 high, GHSA-q2qq-hmj6-3wpp medium). Neither
was reachable from this daemon — hickory is only pulled in for its `Name`
type used by DHCP option encoding, with `default-features = false` — which
is why they were listed as `ignore` entries in deny.toml.

`dhcproto 0.15.0` moved to `hickory-proto ^0.26.1`, the release that fixes
both, so bump the requirement and drop the two ignores instead of carrying
them forever.

- Cargo.toml: dhcproto 0.14 -> 0.15
- Cargo.lock: dhcproto 0.15.0, hickory-proto 0.26.3 (new deps: jni,
  simdutf8, simd_cesu8, walkdir; drops r-efi and rand 0.9)
- deny.toml: remove the RUSTSEC-2026-0118 / -0119 ignores

No source changes were needed; the dhcproto v4 API surface used here
(`Message`, `DhcpOption(s)`, `MessageType`, `DecodeError`/`EncodeError`)
is unchanged.

Verified: `cargo build --locked`, `cargo test --locked --lib --bins`
(170 passed), `cargo clippy --locked --all-targets -- -D warnings -D
clippy::unwrap_used -D clippy::expect_used -D clippy::panic
-D clippy::as_conversions`, `cargo fmt --all -- --check`, and
`cargo deny check` with the ignores removed.

Note: `cargo test --all-targets` fails `test_lease_persistence_across_restart`
on this workstation (post-restart ACK round-trip ~977ms vs the 500ms budget).
That failure reproduces identically with this change stashed, so it is
pre-existing and unrelated; integration tests are skipped in CI anyway.
@feisuzhu
feisuzhu merged commit 41f67a6 into master Nov 10, 2026
11 checks passed
@feisuzhu
feisuzhu deleted the binwang/eve-662 branch November 10, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant