fix: show passphrase toast on sheet - #1165
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThe PR renders the existing app-wide toast inside the hardware-wallet passphrase modal so wrong-passphrase errors remain visible above the sheet.
Confidence Score: 5/5The PR appears safe to merge with no actionable regressions identified. The sheet-local host observes the existing toast state and forwards the established dismissal and gesture callbacks while placing the toast above the modal that previously obscured it.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/ui/screens/transfer/hardware/HwPassphrasePromptSheet.kt | Adds an in-sheet host for the shared toast state, preserving existing dismissal, pause, resume, and haze behavior without an established defect. |
| changelog.d/next/1161.fixed.md | Accurately documents that wrong-passphrase errors are now visible over the hardware transfer passphrase sheet. |
Reviews (1): Last reviewed commit: "fix: harden passphrase sheet toast host" | Re-trigger Greptile
| } | ||
| } | ||
|
|
||
| @Composable |
There was a problem hiding this comment.
This fixes the bug for this sheet but it still exists in the others. Could hoist the host into components/BottomSheet.kt
| onCancel = { closeSheet() }, | ||
| modifier = Modifier.sheetHeight(SheetSize.LARGE, isModal = true) | ||
| ) | ||
| Box(modifier = Modifier.fillMaxSize()) { |
There was a problem hiding this comment.
This makes toast host stretches the sheet to full window height. https://github.com/synonymdev/bitkit-android/pull/1165/changes#r3806178742 would fix this
Fixes #1161
This PR shows the wrong-passphrase error toast on top of the hardware transfer passphrase sheet.
Description
Entering the wrong passphrase on Transfer to Spending already refused the sign and sent the error toast, but the toast sat behind the modal sheet. It was only visible after Cancel. The toast now renders inside the sheet, with the same frosted style as elsewhere.
Preview
Screen_Recording_20260818_122141_Bitkit.Regtest.mp4
QA Notes
Manual Tests
regression:same flow with the correct passphrase → Continue: sheet closes and signing proceeds as before.Automated Checks
TransferViewModelTest.ktis unchanged (toast is still sent; this PR only changes where it is drawn).compileDevDebugKotlinpassed.