Repository navigation
Add folder access states, localized stories and accessible Tabs - #311
Merged
Merged
Conversation
This was referenced Sep 22, 2026
NathanVss
requested review from
PanchoutNathan and
jbpenrath
and removed request for
PanchoutNathan
September 23, 2026 07:56
jbpenrath
reviewed
Sep 23, 2026
2 tasks done
jbpenrath
approved these changes
Oct 6, 2026
jbpenrath
left a comment
jbpenrath
left a comment
Contributor
There was a problem hiding this comment.
Last feedbacks then LGTM ✅
Explain inherited-access changes before applying restrictions while keeping direct access intact. Separate search, import and section state so custom renderers and pending searches remain reliable across modal interactions.
Keep inaccessible folders in the preview flow while preserving their full names and existing navigation. Let consuming apps offer access requests without closing the preview or taking ownership of request processing.
Support keyboard navigation, disabled and icon-only tabs, and responsive layouts through a consistent Tabs API. Rename the CustomTabs export to Tabs and require an accessible label for each tab group.
NathanVss
force-pushed
the
codex/ui-kit-sharing-preview-tabs
branch
from
October 7, 2026 08:21
270ad15 to
3b5e9d4
Compare
- 484849f: Fix Modal layout issues: close button overlap with long titles, full-screen close button position, compact title tokens, dark theme tab item backgrounds - Add accessible Tabs variants, folder access confirmation and denied preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add confirmation dialogs for restricting and reopening folder access, and split ShareModal into focused sections and hooks while preserving its extension points.
Show inaccessible folders in FilePreview without loading their content, with an optional access-request callback. Add a shared Storybook language selector for the five supported locales.
Update Tabs with default and line variants, controlled selection, accessible keyboard navigation, and responsive layouts. Breaking API change:
CustomTabsis renamed toTabs, andaria-labelis now required.Screenshots
Tabs — line variant with icons
Share modal — Restrict access option
FilePreview — restricted folder without access