Conversation
…assing (4 test cases, 28 assertions)
|
just remove the old trapezoidal map and use the new one for everything. Just rename trapezoidalmapFAST trapezoidalmap. |
|
I have verified the new implementation against the old one using the fgm unsteady testcase. It produces identical history and restart files. Map memory for the 7k-point FGM table drops from 18.2 MB to 1.3 MB. |
|
@tkiymaz can you fix the conflicts so the regression tests run again? |
|
Ok great, If you think it's ready just remove the WIP and pr:draft label |
I tested couple of times, I think it is ready. I changed the title and remove the pr:draft label. |
|
@tkiymaz can you fix this sometime soon so it can be merged in before the next release? |
|
@tkiymaz @pcarruscag there are 2 testcases with slightly different residuals, even though they do not use any of the code that was touched as far as I can tell. Both cases are AD-related. The residual mismatch might not be related to this PR. |
Proposed Changes
The original trapezoidal map implementation needs excessive memory for large lookup tables (LUT) (e.g., 300+ MB for tables with ~80k points). This PR introduces a new memory-efficient trapezoidal map implementation (LUT_FAST) for Flamelet-Generated Manifold (FGM) lookup tables, based on LUT algorithm of Pedro Gomes. The new implementation reduces memory usage while maintaining query performance. A new unit test is created and all tests are passed.
Related Work
This code is an implementation of https://github.com/pcarruscag/LUT to SU2.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.