SEP-57: Add muxed address event - #2013
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SEP-57 (T-REX) to describe how transfer events should represent muxed destinations, aligning the document with SEP-41’s muxed-address event semantics.
Changes:
- Bumps SEP-57 metadata (
Updateddate andVersion) and appends a changelog entry for v0.4.0. - Adds a “MuxedTransfer” transfer-event layout intended to carry a destination muxed ID when applicable.
Suppressed comments (1)
ecosystem/sep-0057.md:518
- The
MuxedTransferexample claims to follow SEP-41’s muxed transfer layout, but the field order here isto_muxed_idthenamount. SEP-41 specifies the data shape as{ amount, to_muxed_id }; keeping the same ordering makes it easier for downstream event decoders to support both the plain and muxed layouts consistently.
/// The muxed ID of the destination
pub to_muxed_id: Option<u64>,
pub amount: i128,
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
approved these changes
Sep 9, 2026
Comment on lines
+509
to
+510
| #[contractevent(topics = ["transfer"])] | ||
| pub struct MuxedTransfer { |
Member
There was a problem hiding this comment.
Heads up that with soroban-sdk v28+ if to_muxed_id: None then the result of the MuxedTransfer event will be identical to the Transfer event and we can start describing events with a single shape.
leighmcculloch
enabled auto-merge (squash)
September 9, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Muxed Address Event support to SEP-57