Repository navigation
Conversation
junhsss
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the first-party
steel-clidevice grant to the existing native CLI:Resumable browser approval with bounded non-interactive polling; no localhost callback.
Private, atomic credential state, process-serialized refresh rotation, interrupted-refresh replay protection, and revocation on logout.
Shared Bearer authorization while preserving existing API-key automation and its
Steel-Api-Keyheader.Production defaults with independent environment overrides:
STEEL_AUTH_ISSUERhttps://auth.steel.devSTEEL_AUTH_AUDIENCEhttps://api.steel.devSTEEL_API_URLhttps://api.steel.dev/v1STEEL_CONFIG_DIRisolates test profiles. Saved credentials cannot silently move to another issuer/audience/transport. Session-scoped connection credentials remain separate from product access tokens.Scope
Most existing command changes are mechanical credential adaptations at shared/raw HTTP, multipart, daemon, and WebSocket call sites. Init only returns while authorization is pending instead of continuing as authenticated. Existing installer, skill installation/catalog behavior, setup orchestration and telemetry design are unchanged.
Includes the small CDP URL normalization required by token-only session URLs: root query URLs must generate
GET /?..., notGET ?.... Connection credentials are redacted from display. No hostname override or startup-retry policy is added.No evaluation tooling, transcripts, private environment configuration, account/session data, dependency changes, MCP enablement or signup provisioning is included. Prompt/skill steering is separate work.
Verification
cargo test --all-targetspassed (offline fixtures; existing ignored tests remain ignored).cargo clippy --all-targets -- -D warnings -A clippy::cognitive_complexitypassed. Unmodified large command-dispatch functions still trigger that lint under fully strict Clippy; no unrelated refactor is included.Review / rollout
Draft for scoped API/credential-lifecycle review. This replacement branch has not yet had a fresh live end-to-end validation; automated fixtures are not a production or cross-client readiness claim. Verify service/client registration and run the isolated candidate evaluation before release. A stable native CLI release is needed before the public installer distributes this behavior. This PR does not merge, release or deploy anything.