Skip to content

remove track_caller sentence #13267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShahakShama wants to merge 1 commit into from
Closed

remove track_caller sentence #13267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ Take extra care when reviewing ai-generated code for these issues:

A failure in a unit test should immediately point to the source of the issue, and the clearly display the error encountered. Moreover, it should be possible to debug a test even if the test writer is not available, for example:

- add `#[track_caller]` on test-utils which include a critical assert, so that the trace will be the callsite in the test
- use `assert_eq(result, Ok(<Value>))` over `assert!(result.is_ok())` ---
the former will display the error, and the latter will simply say `expected True, got False`.
- If you're not interested in the value, or if error type doesn't implement `PartialEq`, simply call `result.unwrap()`
Expand Down
Loading