Skip to content

feat: allow plain http connections to s3 - #928

Merged
sweb merged 3 commits into
mainfrom
feat/plain-http-s3-conn
Aug 13, 2026
Merged

feat: allow plain http connections to s3#928
sweb merged 3 commits into
mainfrom
feat/plain-http-s3-conn

Conversation

@sweb

@sweb sweb commented Aug 13, 2026

Copy link
Copy Markdown
Member

Description

@sbernauer and I noticed that http is supported by the native s3 integration of Trino afterall - their docs in 469 were just confusing to read and understand. This was since cleaned up in their documentation (see https://trino.io/docs/469/object-storage/file-system-s3.html#migration-from-legacy-s3-file-system vs. https://trino.io/docs/481/object-storage/file-system-s3.html#migration-from-legacy-s3-file-system) and this PR removes the gate for TLS.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Comment thread tests/test-definition.yaml
@sweb
sweb force-pushed the feat/plain-http-s3-conn branch from 2c617ff to 532e465 Compare August 13, 2026 11:04
@sweb
sweb marked this pull request as ready for review August 13, 2026 11:07
@sweb
sweb requested a review from sbernauer August 13, 2026 11:08
@sweb sweb moved this to Development: In Review in Stackable Engineering Aug 13, 2026

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread tests/templates/kuttl/delta/04-prepare-bucket.yaml.j2 Outdated
Comment thread tests/templates/kuttl/delta/11-assert.yaml.j2 Outdated
Comment thread tests/test-definition.yaml
@sweb
sweb force-pushed the feat/plain-http-s3-conn branch from 532e465 to cf98fc9 Compare August 13, 2026 12:00
@sweb
sweb force-pushed the feat/plain-http-s3-conn branch from cf98fc9 to 9079fe7 Compare August 13, 2026 12:03

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sweb
sweb added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 37cb258 Aug 13, 2026
18 checks passed
@sweb
sweb deleted the feat/plain-http-s3-conn branch August 13, 2026 13:42
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 13, 2026
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 16, 2026
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants