Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve microseconds when serializing
TimeDeltaParameter. Fractional durations now use decimal seconds, such as0.250000or-1.234567. Whole-second durations keep their existing serialized values and task IDs.Numeric strings are parsed with an isolated decimal context and rounded once to microsecond precision. This also keeps long durations exact when tasks are deserialized, without depending on the caller's decimal settings. Non-string inputs retain the existing parsing behavior.
Motivation and Context
TimeDeltaParameteralready accepts fractional seconds, but serialization discarded the fraction. Tasks with durations of 0.25 seconds and 0.75 seconds therefore received the same task ID. In a local scheduler run,luigi.build()reported success while executing only one of them.Task IDs for fractional durations will change to resolve this collision. Whole-second task IDs are unchanged.
Have you tested this? If so, how?
tox run -e lintandtox run -e docspass.tox run -e py310-core: 1,560 passed, 24 skipped, 5 failed. All five failures are existingtest/server_test.py::_ServerTestsetup errors (TypeError: 'str' object is not callable), independently reproduced on unchanged master in the same environment. No new failures remain.