Repository navigation
Fix ISO week construction at the minimum supported year - #3464
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week(1, 1)raisesOverflowErroreven though both ends of the interval are valid Python dates. The constructor starts its search ten days before January 1, which underflows before it can find the requested week.Use
datetime.date.fromisocalendarto obtain the Monday directly. This also removes the day-by-day search for ordinary weeks. The seven-day half-open interval is unchanged.Tests cover the minimum year, weeks crossing calendar-year boundaries, a valid week near the maximum year, and invalid ISO week numbers. The minimum-year regression fails before the change; 264 related date, parameter, and range tests plus seven subtests pass afterward. Ruff and formatting checks pass.