Skip to content

Remove deprecated assignment to .shape #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgeier wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −11
Open

Remove deprecated assignment to .shape #641

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a85f1d2
Replace assignment to .shape by np.reshape()
mgeier Aug 22, 2026
8a8ccec
Use more obscure implementation using a sub-array dtype
mgeier Aug 22, 2026
626fcb0
Less obscure, slightly more complicated but maybe faster implementation
mgeier Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/sounddevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ def callback_ptr(iptr, optr, frames, time, status, _):
def callback_ptr(iptr, optr, frames, time, status, _):
data = _array(
_buffer(iptr, frames, self._channels, self._samplesize),
self._channels, self._dtype)
self._channels, self._dtype, self._samplesize)
return _wrap_callback(callback, data, frames, time, status)

elif kind == 'output' and wrap_callback == 'buffer':
Expand All @@ -875,7 +875,7 @@ def callback_ptr(iptr, optr, frames, time, status, _):
def callback_ptr(iptr, optr, frames, time, status, _):
data = _array(
_buffer(optr, frames, self._channels, self._samplesize),
self._channels, self._dtype)
self._channels, self._dtype, self._samplesize)
return _wrap_callback(callback, data, frames, time, status)

elif kind == 'duplex' and wrap_callback == 'buffer':
Expand All @@ -896,10 +896,12 @@ def callback_ptr(iptr, optr, frames, time, status, _):
ichannels, ochannels = self._channels
idtype, odtype = self._dtype
isize, osize = self._samplesize
idata = _array(_buffer(iptr, frames, ichannels, isize),
ichannels, idtype)
odata = _array(_buffer(optr, frames, ochannels, osize),
ochannels, odtype)
idata = _array(
_buffer(iptr, frames, ichannels, isize),
ichannels, idtype, isize)
odata = _array(
_buffer(optr, frames, ochannels, osize),
ochannels, odtype, osize)
return _wrap_callback(
callback, idata, odata, frames, time, status)

Expand Down Expand Up @@ -1490,8 +1492,9 @@ def read(self, frames):
"""
dtype, _ = _split(self._dtype)
channels, _ = _split(self._channels)
samplesize, _ = _split(self._samplesize)
data, overflowed = _InputStreamBase._raw_read(self, frames)
data = _array(data, channels, dtype)
data = _array(data, channels, dtype, samplesize)
return data, overflowed


Expand Down Expand Up @@ -2788,12 +2791,11 @@ def _buffer(ptr, frames, channels, samplesize):
return _ffi.buffer(ptr, frames * channels * samplesize)


def _array(buffer, channels, dtype):
def _array(buffer, channels, dtype, samplesize):
"""Create NumPy array from a buffer object."""
import numpy as np
data = np.frombuffer(buffer, dtype=dtype)
data.shape = -1, channels
return data
shape = len(buffer) // (samplesize * channels), channels
return np.ndarray(shape, dtype=dtype, buffer=buffer)


def _split(value):
Expand Down