Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Research result
The little-endian adapter matches the existing checked big-endian converter in script size, stack peak, and opcode count. It removes the need for a caller-side four-bit reversal when a ScriptNum or scalar consumer needs least-significant-bit-first nibble output. Witness nibbles remain hostile: checked mode enforces numeric range 0..=15, while canonical encoding and protocol binding remain caller obligations. Deployment remains unclassified; local evidence uses the repository tapscript executor with the strict stack limit.
Tests
cargo test --locked arithmetic::u4::bits::tests -- --nocapture --skip batch_size_guard_matches_the_strict_stack_peakcargo test --locked arithmetic::u4::bits::tests::batch_size_guard_matches_the_strict_stack_peak -- --exact --nocapturepython3 tools/kb.py validateUPDATE_PRIMITIVE_METRICS=1 cargo test --locked --test primitive_metrics(6 passed, 1 ignored)cargo test --locked --test primitive_metrics(6 passed, 1 ignored)