Conversation
brenorb
force-pushed
the
feat/u4-nibbles-to-byte
branch
from
September 11, 2026 14:21
3f07fea to
39a6c69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u4_nibbles_to_byteto pack a high/low nibble pair into one byteValidation
cargo test --locked arithmetic::u4::bits::tests::exhaustive_nibble_pairs_pack_to_bytescargo test --locked arithmetic::u4::bits::tests::checked_nibble_pair_rejects_malformed_inputscargo test --locked --test primitive_metricspython3 tools/kb.py validatecargo fmt --checkgit diff --checkThe full repository test suite was intentionally not run; the focused primitive and metric checks pass. Dynamic opcode counting is unavailable in the local executor, so the documentation reports static non-push counts.