Repository navigation
fix(engine.io-parser): respect binary view boundaries in browsers - #5583
Open
minjungsung wants to merge 1 commit into
Open
minjungsung wants to merge 1 commit into
minjungsung wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser binary decoding currently returns the entire backing buffer for a typed-array view. For example, decoding
Uint8Array.of(1, 2, 3, 4).subarray(1, 3)withbinaryType: 'arraybuffer'returns all four bytes instead of[2, 3]. This also affects WebTransport payload chunks that are views into a larger buffer.Return only the view's byte range when its offset or length differs from the backing buffer. Keep the existing buffer for full-span views. Add shared regressions covering offset views, prefix views, empty views, and full-span views.
Validation: three browser regressions fail before the fix. All 32 browser tests pass afterward in headless Chrome, and the complete engine.io-parser workspace test command passes (format, both TypeScript builds, Node tests).
AI assistance: implementation, tests, and this description were prepared with Codex.