Skip to content

Add tsk check to set a review check's state (T172) - #274

Closed
Tobi4161 wants to merge 2 commits into
smarzban:mainfrom
Tobi4161:tsk/t172-add-tsk-check-to-set-a-review
Closed

Tobi4161 wants to merge 2 commits into
smarzban:mainfrom
Tobi4161:tsk/t172-add-tsk-check-to-set-a-review

Conversation

@Tobi4161

@Tobi4161 Tobi4161 commented Nov 2, 2026

Copy link
Copy Markdown

Problem

Only the board could mark a review check. Pocket Herd (T84) needs to mark checks from the phone, through the CLI.

Solution

tsk check <task> <n> <state> sets check <n> (1-based, in tsk list T12 --json order) of the open review round to open, passed, or failed.

  • Saves through DomainState::set_check, which writes the existing check_set event, like Enter on a check. No undo entry, matching the board.
  • Setting the state it already has saves nothing and exits 0.
  • Refusals: unknown-task, soft-deleted-task, not-in-review, unknown-check (exit 1). A bad state word or number is a usage error (exit 2).
  • Output: T12 check 2 passed.
  • New src/cli/check.rs, wired through parser, router, presenter, main.rs, and tsk help check.
  • Docs: a ## check section, the Commands table, and the exit-contract row in cli.md. Also llms.txt (Review concept) and a CHANGELOG Added line. The skill is unchanged on purpose: checks are the user's verification.

Testing

  • tests/cli_check.rs covers each state, the idempotent repeat (byte-identical store), every refusal (store unchanged), a deleted task, no undo entry, and the board painting the new state after a reload.
  • cli_help covers the reference sections, 80-column fit, and trailing whitespace.
  • Green bar on the pinned 1.96 toolchain: fmt, clippy, and every test except git_base::two_tsk_processes_on_one_state_dir_share_one_fetch. That test fails the same way on the base commit 8d714a2 in this environment, so the failure is not from this change.

🤖 Generated with Claude Code

Tobias Wölm and others added 2 commits November 2, 2026 20:02
tsk check <task> <n> <state> sets one check of the open review round
to open, passed, or failed through DomainState::set_check, like Enter
on a check. A repeat changes nothing; refusals: unknown-task,
soft-deleted-task, not-in-review, unknown-check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name the transition apply() like steps, read state words through
CheckState::from_name, treat an oversized check number as unknown-check,
and test the board reload, the missing undo entry, and untouched replies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Tobi4161
Tobi4161 requested a review from smarzban as a code owner November 2, 2026 19:05
@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the smarzban Team on Vercel.

A member of the Team first needs to authorize it.

@jovric jovric Bot added the enhancement New feature or request label Nov 2, 2026
@Tobi4161

Tobi4161 commented Nov 2, 2026

Copy link
Copy Markdown
Author

Opened here by mistake; this belongs on my fork. Sorry for the noise.

@Tobi4161 Tobi4161 closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant