Adding New Level: Lua Metatable hooks - #128
Conversation
jkcso
left a comment
There was a problem hiding this comment.
@TheDarkThief Thanks for your work! I left comments to improve it and accept it, good job man!
|
|
||
|
|
||
| --- Generates a bitmap image | ||
| -- @param request: The table which we will populate with images |
There was a problem hiding this comment.
I understand what you try to say but please rewrite it in a more explanatory way, such as for example that the table will contain pixels for the image that will be populated and it's being represented as a table.
There was a problem hiding this comment.
Went into a bit more depth in the comment
|
I've made the requested changes, as well as switch to the Busted library making it easier to setup Github CI as well as make the error messages a bit clearer |
|
Hi @TheDarkThief 👋 — just a heads-up on why this PR is currently stuck, in case it helps you revive it. Since it was opened,
To get it merge-ready you'd likely want to:
The level itself is still solid — (Edit: I'd briefly linked a rebased branch here but have since removed it — the notes above should be enough to update the PR directly.) |
|
Hello @ZayanKhan-12 , thank you for bringing this back up, I'll be able to work on it tomorrow. |
|
I have made the required changes, if something else needs work LMK and I'd be happy to get it done |
|
@jkcso Could you please review the changes |
Summary
Adding a new level demonstrating Lua metatables, and how a malicious actor can hook into them
Changes
Created a level where a user requests the client to populate a table, where a malicious actor gains remote code execution due to improper sanitation.
Task list