Repository navigation
refactor(tanstack query): signal render reactivity via onRender handler - #76
Merged
Merged
Conversation
…handler The shared observer bases no longer hard-code setOptions/setQueries in hostWillRender. They just fire the optional `onRender` handler, letting each consumer opt in: - classic useQuery/useQueries pass `onRender: () => reArm()` for pull-based reactivity (their only reactivity), via a lazily-referenced handle. - signal $useQuery/$useQueries omit `onRender` entirely — they react purely through their client `effect` on the options signal plus the server settle. `onRender` narrows to `() => void` (no consumer needs the result). Removes the stale "consider to remove for signal query" TODO. The pull-based array-growth test for the signal hook is dropped (intentionally-removed behavior; the signal-driven growth test and the classic pull test cover the paths). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
stephenlautier
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.