Skip to content

fix(knowledge): simplify connector management - #7788

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/kb-connector-modal-layout
Sep 11, 2026
Merged

fix(knowledge): simplify connector management#7788
waleedlatif1 merged 2 commits into
stagingfrom
codex/kb-connector-modal-layout

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Simplify connected-source rows with standard action menus, clear recovery prompts, and on-demand sync history.
  • Keep document filters beside stable tabs, preserve keyboard focus, and remove the Full resync action and guide references.

Type of Change

  • Bug fix

Testing

235 focused tests passed. Manually reviewed 55 UI states using real components with simulated data, including keyboard navigation, recovery, confirmations, and document actions. All workspace type-checks, lint, 46 repository audits, block-registry checks, and generated-artifact checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 10:47pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported history-disclosure accessibility issue is fully fixed and no new actionable failures remain.

Summary

  • Moves sync history into an on-demand disclosure with independent state and accessible collapse/focus restoration.
  • Removes the Full resync action and corresponding documentation.
  • Improves credential-recovery prompts and connector-specific OAuth messaging.
  • Keeps document filters beside stable modal tabs while preserving filter state.
  • Updates connector query behavior, modal layout, and focused regression coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Connection row] --> B[Connection actions menu]
  B --> C[Sync now]
  B --> D[Settings]
  B --> E[Pause or resume]
  B --> F[Remove connection]
  B --> G[Sync history]
  G --> H[Expanded history panel]
  H --> I[Hide history]
  I --> A
Loading

Reviews (2) · Last reviewed commit: "fix(knowledge): keep history collapse ac..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 45ab0f2 into staging Sep 11, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/kb-connector-modal-layout branch September 11, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant