Skip to content

fix(sidebar): change organization logos from the icon - #7785

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/org-logo-icon-upload
Sep 11, 2026
Merged

fix(sidebar): change organization logos from the icon#7785
waleedlatif1 merged 1 commit into
stagingfrom
codex/org-logo-icon-upload

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Click the organization logo to change it; remove the separate upload menu action.
  • Reuse the existing identity tile, menu, tooltip, and upload flow, including keyboard access and pending/error handling. Public API contracts are unchanged.

Type of Change

  • Bug fix

Testing

  • 73 focused sidebar and upload tests passed, including mouse/keyboard activation, permissions, pending uploads, and retries.
  • Checked the menu layout and keyboard focus in the running app.
  • Cleanup review, application type check, lint, all 46 audits, block registry, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 8:29pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, accessibility, or repository-rule violations identified.

Summary

  • Preserves the existing permission gate and collapsed-sidebar behavior.
  • Keeps the menu open while invoking the file picker.
  • Retains pending, success, error, and same-file retry handling.
  • Adds focused coverage for mouse, keyboard, permissions, and upload lifecycle behavior.

Reviews (1) · Last reviewed commit: "fix(sidebar): change organization logos ..."

@waleedlatif1
waleedlatif1 merged commit 64bce6a into staging Sep 11, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/org-logo-icon-upload branch September 11, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant