Skip to content

fix(sidebar): simplify organization controls and add logo uploads - #7783

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/org-sidebar-refinements
Sep 11, 2026
Merged

fix(sidebar): simplify organization controls and add logo uploads#7783
waleedlatif1 merged 2 commits into
stagingfrom
codex/org-sidebar-refinements

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the extra workspace search field from the organization sidebar and reuse the existing inline rename row across sidebar views.
  • Let organization owners and admins upload a logo from the organization menu using shared image validation and upload infrastructure.
  • Scope logo uploads to the organization, recheck administrator access, reject concurrent logo overwrites, and make completion idempotent. Reclaim replaced images through existing upload retention. Add a backward-compatible upload-purpose enum value.

Type of Change

  • Bug fix
  • New feature

Testing

Focused unit/UI tests and real PostgreSQL concurrency/retention tests passed, along with type checks, lint, all 46 audits, and migration safety checks. Verified rename save/cancel and logo rendering in both sidebar modes. Tested real local image transfers, persistence, replacement, and completion replay. Native file selection could not be automated.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 11, 2026 8:10pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The reviewed changes appear safe to merge, with no outstanding actionable findings.

Summary

  • Reuses a shared inline rename row and removes the duplicate workspace search field.
  • Adds administrator-only organization-logo selection, validation, upload, cache invalidation, and rendering.
  • Rechecks organization authorization during finalization and prevents stale uploads from replacing newer branding.
  • Retains active logo ownership records while reclaiming superseded objects through the upload cleanup lifecycle.
  • Adds bounded, ownership-aware file-result processing and versioned integration download outputs.

Diagram

sequenceDiagram
  participant Admin
  participant Sidebar
  participant Upload as Upload lifecycle
  participant DB as Database
  participant Storage
  Admin->>Sidebar: Select organization logo
  Sidebar->>Upload: Create organization-scoped session
  Upload->>DB: Capture current logo and verify admin
  Sidebar->>Storage: Transfer validated image
  Sidebar->>Upload: Complete session
  Upload->>DB: Lock session and organization
  Upload->>DB: Recheck admin and expected logo
  Upload->>DB: Atomically publish path and completion marker
  Upload-->>Sidebar: Return stored logo
  Sidebar->>Sidebar: Invalidate organization queries
  Note over DB,Storage: Retention preserves the active logo and later removes superseded objects
Loading

Reviews (2) · Last reviewed commit: "fix(uploads): guard logo replacements an..."

Comment thread apps/sim/lib/uploads/contexts/organization-logo/application.ts
Comment thread apps/sim/lib/uploads/contexts/organization-logo/application.ts
Comment thread apps/sim/hooks/queries/organization-logo.ts
@waleedlatif1
waleedlatif1 force-pushed the codex/org-sidebar-refinements branch from 5851b35 to 598f18f Compare September 11, 2026 20:08
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 281ba8c into staging Sep 11, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/org-sidebar-refinements branch September 11, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant