Skip to content

fix(workflows): surface workflow import failures - #7768

Merged
j15z merged 2 commits into
stagingfrom
codex/fix-workflow-import-errors
Sep 12, 2026
Merged

fix(workflows): surface workflow import failures#7768
j15z merged 2 commits into
stagingfrom
codex/fix-workflow-import-errors

Conversation

@j15z

@j15z j15z commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show filename-specific error toasts when individual workflow imports fail, including malformed workflow JSON, while continuing other imports.
  • Replace raw ZIP extraction errors with “Failed to import ZIP file. Check that it is a valid ZIP archive.”
  • Surface folder setup and other import failures, and use stable mutation functions in the import callbacks.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • Verified in Chrome: malformed JSON and corrupt ZIP files show the new messages, and the import control recovers.
  • Verified in Chrome: a simulated workflow-creation connection failure shows the filename and error; retrying the same valid JSON succeeds and survives reload.
  • App type check, repository lint, all 46 audits, block-registry check, and docs-manifest check pass. Generated artifacts are in sync.
  • No new automated tests for this UI feedback change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Verified both notifications in Chrome. No screenshots attached.

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 12, 2026 8:15pm UTC

Request Review

@j15z
j15z force-pushed the codex/fix-workflow-import-errors branch from 9fbb134 to 455d3e2 Compare September 12, 2026 20:13
@j15z
j15z changed the base branch from codex/fix-cli-interrupted-responses to staging September 12, 2026 20:13
@j15z
j15z marked this pull request as ready for review September 12, 2026 20:14
@j15z

j15z commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@j15z

j15z commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@j15z I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new error paths are correctly scoped and preserve continued importing after individual workflow failures.

Summary

  • Reports malformed or otherwise failed workflows with filename-specific error toasts.
  • Replaces low-level ZIP loading errors with a clear archive-validation message.
  • Surfaces setup-level import failures through the outer error handler.
  • Uses stable mutation functions in memoized import callbacks.

Reviews (1) · Last reviewed commit: "fix(workflows): clarify invalid import f..."

@j15z
j15z merged commit 3bdc279 into staging Sep 12, 2026
7 checks passed
@j15z
j15z deleted the codex/fix-workflow-import-errors branch September 12, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant