Skip to content

fix(slack): skip completed shared app verification setup - #7756

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
codex/skip-shared-slack-verification
Sep 11, 2026
Merged

fix(slack): skip completed shared app verification setup#7756
TheodoreSpeaks merged 2 commits into
stagingfrom
codex/skip-shared-slack-verification

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Skip the secondary Slack setup modal when the shared app and member authorization are already configured.
  • Keep the existing repair action for outdated member access, plus custom-app verification and personal account OAuth.

Type of Change

  • Bug fix

Testing

  • 55 focused tests passed, covering setup completion, outdated member-access repair and retries, missing configuration, loading and failure states, and existing OAuth behavior.
  • Repository lint, generated-artifact, and application/API/tool-boundary audits passed.
  • Typechecks run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 2:29am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because completed configurations are skipped without removing the repair flow for outdated member access.

Summary

  • Loads the organization account configuration before determining that shared-app setup is complete.
  • Restores the existing member-authorization flow for needs_update.
  • Adds coverage for completed, incomplete, loading, failure, retry, and outdated-access states.
  • The previous finding was manually resolved after the repair action was restored and is no longer outstanding.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Open Slack setup] --> B{Shared app selected?}
  B -- No --> C[Existing custom-app or personal OAuth flow]
  B -- Yes --> D{Installation and account queries succeeded?}
  D -- No --> E[Show loading, error, or app-management state]
  D -- Yes --> F{Installation valid and available?}
  F -- No --> E
  F -- Yes --> G{Member configuration status}
  G -- ready --> H[Close secondary setup modal]
  G -- needs_update --> I[Show Update member access]
  G -- other or missing --> E
  I --> J[Run existing member authorization flow]
Loading

Reviews (2) · Last reviewed commit: "fix(slack): preserve outdated member acc..."

Comment thread apps/sim/ee/credential-groups/components/slack-managed-users-modal.tsx Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks
TheodoreSpeaks merged commit d7fb4f7 into staging Sep 11, 2026
34 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/skip-shared-slack-verification branch September 11, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant