Repository navigation
Refresh test certs and CRLs - #46
Merged
Merged
Conversation
Removes about 1k symbols, including a conflicting `malloc` definition. (cherry picked from commit 9c57211)
jrose-signal
force-pushed
the
jrose/refresh-test-certs
branch
from
October 17, 2026 01:11
e5c3517 to
885ff3b
Compare
Author
|
Hm, upstream's "we update the tests as needed" does make it hard to get a clean CI build on an older tag. |
Renew the committed CA and leaf certificates used by the TLS test suite after their August 2026 expiration. Deploy risk: test fixtures only; runtime certificates and package behavior are unchanged. (cherry picked from commit f8de5f9)
Keep certificate fingerprints, validity assertions, signatures, and bundled certificate expectations aligned with the renewed test fixtures. Deploy risk: test expectations only; runtime behavior is unchanged. (cherry picked from commit 0332e28)
(cherry picked from commit 485da8b)
(cherry picked from commit 542cb07)
Co-authored-by: Andrew <andrew@signal.org>
jrose-signal
force-pushed
the
jrose/refresh-test-certs
branch
from
October 19, 2026 20:04
885ff3b to
216996c
Compare
Merged
moiseev-signal
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the upstream cert refreshes (and one bindgen tweak, and some Clippy appeasement) from v5.3.0, then updates the test CRLs added in Signal's fork in the same way (and adds a script to do so in the future, so we don't change how they're generated for no reason).
Groundwork for updating to v5.3.0 (which looks like it's going to be pretty smooth, but nevertheless it's nice to have all tests passing before the update).