Skip to content

Use GitHub domain front for China censorship circumvention - #6386

Draft
AcideFluorhydrique wants to merge 3 commits into
signalapp:mainfrom
AcideFluorhydrique:fix/china-github-sni
Draft

AcideFluorhydrique wants to merge 3 commits into
signalapp:mainfrom
AcideFluorhydrique:fix/china-github-sni

Conversation

@AcideFluorhydrique

@AcideFluorhydrique AcideFluorhydrique commented Oct 30, 2026 •

Copy link
Copy Markdown

Contributor checklist

Administrative:

Testing:

  • I have verified that the issue reproduces on latest main.
    • I have included a screen recording documenting the issue reproducing.
  • I have verified that the issue no longer reproduces on my branch.
    • I have included a screen recording documenting the issue no longer reproducing.
  • I have thoroughly tested this change, and I am not aware of any regressions to existing features or behaviors.
  • I have tested my contribution on these devices:
    • iDevice A, iOS X.Y.Z
    • iDevice B, iOS X.Y.Z

Commits:

  • My commits are rebased on latest main.
  • My commits are well-structured for review.

Description

Refs #6385

Selecting China for censorship circumvention falls back to the Google-only
default configuration, because CN has no frontingDomain. This points CN
at a Fastly configuration that contains only github.githubassets.com, the
front that performed best from mainland China in the reachability data in the
issue. pinterest.com and www.redditstatic.com are left out so that retries
are not spent on fronts that were unreliable or blocked there.

+86 is intentionally not added to censoredCountryCodes: users in mainland
China often do not use a +86 number. This only changes behavior for users who
manually select China.

Testing

The Testing checklist is left unchecked because I have not done those steps.

  • Reproduction: a tester in mainland China saw this on the released app, not a
    build of main. Details and limits are in the issue.
  • This branch has not been compiled or run on a device. I can't run the Xcode
    version this repo requires on Xcode27.
  • This is not confirmed to fix attachments.

I'm keeping this as a draft for that reason. If this approach looks right,
someone who can build it would need to verify it from a mainland China network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant