Skip to content

[Fix] Rename output_file_path to output_folder_path for sample_from_conditions() and sample_remaining_columns() - #2976

Merged
R-Palazzo merged 3 commits into
v2.0.0from
fix-output_folder_path
Sep 4, 2026
Merged

[Fix] Rename output_file_path to output_folder_path for sample_from_conditions() and sample_remaining_columns()#2976
R-Palazzo merged 3 commits into
v2.0.0from
fix-output_folder_path

Conversation

@R-Palazzo

@R-Palazzo R-Palazzo commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

We discussed the renaming of the parameter for these methods in this Slack thread

@R-Palazzo R-Palazzo self-assigned this Sep 3, 2026
@R-Palazzo
R-Palazzo requested a review from a team as a code owner September 3, 2026 15:00
@sdv-team

sdv-team commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@R-Palazzo
R-Palazzo changed the base branch from v2.0.0 to main September 3, 2026 15:03
@R-Palazzo
R-Palazzo changed the base branch from main to v2.0.0 September 3, 2026 15:04
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.89%. Comparing base (be46255) to head (298c579).

Files with missing lines Patch % Lines
sdv/single_table/utils.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v2.0.0    #2976   +/-   ##
=======================================
  Coverage   97.88%   97.89%           
=======================================
  Files          66       66           
  Lines        7669     7684   +15     
=======================================
+ Hits         7507     7522   +15     
  Misses        162      162           
Flag Coverage Δ
integration 83.96% <84.61%> (+0.14%) ⬆️
unit 96.25% <96.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo
R-Palazzo merged commit 3b58e7b into v2.0.0 Sep 4, 2026
90 of 104 checks passed
@R-Palazzo
R-Palazzo deleted the fix-output_folder_path branch September 4, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants