Repository navigation
Conversation
Author
|
The PyPy3.11 job fails during dependency installation: NumPy has no usable wheel for that interpreter, and the workflow disables building NumPy from source. Configure, build and tests are skipped in that job. The reported CPython native and downstream Hist checks pass; the free-threaded macOS wheel job is still running. Job: https://github.com/scikit-hep/boost-histogram/actions/runs/38534673422/job/115799656501 |
henryiii
force-pushed
the
fix/numpy-density-bin-widths
branch
from
October 30, 2026 20:45
ecf251c to
7b41a0c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final bin is widened to include its right endpoint, but density uses that widened width while returning the original edges. For narrow bins at a large offset, the resulting density does not integrate to one:
Compute density bin volumes from the returned edges, using sparse meshgrids for multiple axes. The count/object return paths keep their existing behavior.
Sixteen of the 20 new regressions fail on current
develop; all pass after, covering one to three dimensions, positive/negative offsets, weights and the 1D/2D entry points. On 2,048 previously recorded clock samples, the affected final-bin relative error reaches 50% before; all 12 configurations agree with independent count/bin-volume normalization to at most 2.2e-16 after. All count results and 12 object controls remain exact.Local native suites: Python3.12, 1,238 passed/4 xfailed; Python3.14, 1,237 passed/1 skipped/4 xfailed. Full
prek run -a, including strict mypy, passes.