Skip to content

electron-chrome-extensions: After adding tab exception if page quickly redirects (e.g. 302) #178

Description

@GramboStorm

When adding a tab electron-chrome-extensions will bind to did-start-navigation.
tab.on('did-start-navigation', this.onBeforeNavigate.bind(this, tab))

However, it is possible for the frame to be destroyed before this is received (for example if there is a very quick http 302)
Therefore following line should check that the frame.isDestroyed() is false
/src/browser/api/web-navigation.ts
var getFrameId = (frame) => frame === frame.top ? 0 : frame.frameTreeNodeId;

Maybe return -1 in this case?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions