Skip to content

Extract Fetch and Error Handling From Loads - #4186

Open
knoppiks wants to merge 1 commit into
mainfrom
4150-extract-fetch-and-error-handling-from-loads
Open

knoppiks wants to merge 1 commit into
mainfrom
4150-extract-fetch-and-error-handling-from-loads

Conversation

@knoppiks

@knoppiks knoppiks commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Closes: #4150

@knoppiks knoppiks self-assigned this Sep 3, 2026
@knoppiks knoppiks linked an issue Sep 3, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (c346285) to head (884ef0b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4186   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         443      443           
  Lines       28288    28288           
  Branches      660      658    -2     
=======================================
  Hits        27319    27319           
- Misses        464      466    +2     
+ Partials      505      503    -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knoppiks
knoppiks force-pushed the 4150-extract-fetch-and-error-handling-from-loads branch from a613371 to e1ac4d5 Compare September 4, 2026 11:56
@knoppiks
knoppiks marked this pull request as ready for review September 4, 2026 11:56
Comment thread modules/frontend/src/lib/metadata.ts Outdated

const bundle = (await res.json()) as Bundle;

// The status is carried in the body as well, like `fetchFhir` does it,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment should be removed

Comment thread modules/frontend/src/lib/fetch.ts Outdated
/**
* Reads the FHIR resource at `url`.
*
* This is how a load reads from the FHIR API — every resource endpoint,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove that overspecific examples

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and document the thrown execptions

Closes: #4150
Signed-off-by: Jonas Wagner <jwagner@knoppiks.de>
@knoppiks
knoppiks force-pushed the 4150-extract-fetch-and-error-handling-from-loads branch from e1ac4d5 to 884ef0b Compare September 5, 2026 09:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract Fetch and Error Handling From Loads

2 participants