fix(bootstrap): add missing install_ubuntu_onedir_post function - #2129
Merged
Conversation
Ubuntu had install_ubuntu_stable_post and install_ubuntu_git_post but no install_ubuntu_onedir_post. Since ITYPE is set to onedir for onedir installs, the post-install function dispatch never matched any candidate name and silently skipped enabling the salt-* systemd services, causing check_install_services to fail on Ubuntu 24.04. Add install_ubuntu_onedir_post as a thin wrapper delegating to install_ubuntu_stable_post, matching the existing pattern used by other distros (e.g. install_suse_15_onedir_post, install_rocky_linux_onedir_post). Fixes saltstack#2128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ubuntu had install_ubuntu_stable_post and install_ubuntu_git_post but no install_ubuntu_onedir_post. Since ITYPE is set to onedir for onedir installs, the post-install function dispatch never matched any candidate name and silently skipped enabling the salt-* systemd services, causing check_install_services to fail on Ubuntu 24.04.
Add install_ubuntu_onedir_post as a thin wrapper delegating to install_ubuntu_stable_post, matching the existing pattern used by other distros (e.g. install_suse_15_onedir_post, install_rocky_linux_onedir_post).
What issues does this PR fix or reference?
Fixes #2128