Write alpine service scripts directly - #2117
Merged
Merged
Conversation
twangboy
approved these changes
Jun 26, 2026
Contributor
|
Please rebase and address the lint failures |
twangboy
requested changes
Jul 9, 2026
twangboy
force-pushed
the
fix-alpine-service-files
branch
from
August 31, 2026 19:44
a94405f to
1f412a1
Compare
This script targets POSIX sh (shellcheck -s sh), which flags 'local' as undefined (SC3043) and fails CI lint. script_path doesn't need scoping here anyway -- it matches how every other variable in this file (including fname in this same loop) is already handled.
twangboy
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Writes alpine service files for salt daemons directly, rather than trying to download them from the salt repo (which deprecated them a while ago). This mirrors how it's done for gentoo.
What issues does this PR fix or reference?
Alpine install is broken. In the
install_alpine_linux_post()phase, it tries to install OpenRC scripts from<salt-repo>/pkg/alpine/..., but they're not there anymore. They were moved toold/when they got deprecated 3.5 years ago.