Repository navigation
Check the zero groups before the drain in the stale-new-group test (G5 x G2b) - #1164
Merged
mmmries merged 1 commit intoOct 19, 2026
Merged
Conversation
…ince the zero-group GC now removes them after it G5's test expected the recomputed zero groups to still be in the hidden table after settle(); G2b's zero-group GC deletes them once the drained prefix passes their stamp. Each PR was green alone. The assertion that the basis refused the insert's page now runs before the drain; the oracle check after settle is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
partition_group_basishas one failing test,an_undrained_change_naming_a_new_group_of_a_dropped_leaf_is_refused: it got[]where it expected the hidden groups(4,0,t),(5,0,t),(6,0,t). G5 (#1159) wrote the test; G2b (#1160) added the zero-group GC. Each was green alone. Aftersettle()the GC deletes the recomputed zero groups once the drained prefix passes their stamp, so the post-drain assertion on the hidden table can no longer hold.Change
Test-only. The assertion that the recompute left the groups at zero with a basis (which is what refuses the stale insert's page) now runs before the drain. The oracle check after
settle()(assert_right) is unchanged, so the end state is still checked against a freshGROUP BY.Verification
cargo test -p trellis --test partition_group_basis: 28 passed (it failed deterministically on main before).verifygreen on this tree: 3548 passed, 0 failed, 39 ignored.🤖 Generated with Claude Code