Skip to content

Status updates - #551

Open
Sam Beveridge (00salmon) wants to merge 5 commits into
masterfrom
status-updates
Open

Sam Beveridge (00salmon) wants to merge 5 commits into
masterfrom
status-updates

Conversation

@00salmon

Copy link
Copy Markdown
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI balanced review requested due to automatic review settings September 28, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unconditional low-balance notices violate documented alert precedence, and the release note omits referral-status changes.

Review effort: Balanced
Findings: 2 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Updates payout alerts and referral status handling.

Changes:

  • Separates low-balance notices from payout hold statuses and suppresses them at zero balance.
  • Displays retracted referrals as cancelled.
  • Updates types, stories, documentation, and tests.
File Description
saasquatch.d.ts Adds conversion-retraction timestamps.
tax-and-cash/​utils.ts Updates low-balance detection.
tax-and-cash/​TaxForm.stories.tsx Updates threshold story data.
useTaxAndCashDashboard.tsx Exposes threshold state.
TaxAndCashDashboardView.stories.tsx Adds combined alert stories.
sqm-tax-and-cash-dashboard-view.tsx Renders threshold notices independently.
sqm-tax-and-cash-dashboard/​readme.md Updates generated dashboard API documentation.
usePayoutStatus.ts Revises hold resolution and threshold state.
sqm-payout-status-alert-view.tsx Supports multiple payout notices.
sqm-payout-status-alert/​readme.md Updates generated alert API documentation.
PayoutStatusAlert.stories.tsx Adds threshold and hold examples.
useReferralTable.tsx Queries conversion-retraction dates.
sqm-referral-table.tsx Updates the documented example.
ReferralTableCell.stories.tsx Adds retracted-status examples.
referralStatus.ts Centralizes referral status derivation.
referralStatus.spec.ts Tests referral status precedence.
mockReferralData.ts Adds retraction data to mocks.
sqm-referral-table-status-column.tsx Renders retracted referral status and copy.
referral-table-status-column.feature Documents retraction behavior.
sqm-referral-table-status-cell.tsx Maps referral statuses to badge styles.
components.d.ts Updates generated component types.
.changeset/​odd-experts-check.md Adds release metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/mint-components/.changeset/odd-experts-check.md Outdated
Copilot AI review requested due to automatic review settings September 28, 2026 22:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The changeset repeats an already-released fix and does not describe this PR’s referral-status behavior.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (3)

Comment thread packages/mint-components/.changeset/odd-experts-check.md Outdated
Copilot AI review requested due to automatic review settings September 28, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The retraction state is consistently queried, typed, rendered, documented, and covered by focused tests.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants