Set type of F_RDLCK F_WRLCK and F_UNLCK flags to c_short - #5403
Open
LusterSourav wants to merge 1 commit into
Open
Set type of F_RDLCK F_WRLCK and F_UNLCK flags to c_short#5403LusterSourav wants to merge 1 commit into
LusterSourav wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in an Android module cc @maurer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constants are assigned to the l_type field of struct flock, which is declared as a short on every Linux platform. Changing the type from c_int to c_short will likely not break existing programs. It might introduce warnings about no longer needed conversions to c_short though.
SEEK_SET, SEEK_CUR and SEEK_END keep their c_int type, since they are also passed to lseek where an int is required, per the discussion in issue 1619.
Fixes #1619